Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intermittent undefined page in trace details page #6084

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Sep 26, 2024

Summary

  • intermittent undefined page in trace details page on back navigation
  • the block link was not getting generated correctly because of misconfiguration

Related Issues / PR's

fixes https://github.com/SigNoz/engineering-pod/issues/1807

Screenshots

Screen.Recording.2024-09-26.at.4.33.04.PM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Collaborator

@ahmadshaheer ahmadshaheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @vikrantgupta25, LGTM.

@vikrantgupta25 vikrantgupta25 merged commit ef4b70f into develop Sep 26, 2024
13 of 14 checks passed
@vikrantgupta25 vikrantgupta25 deleted the trace-intermittent-undefined-issue branch September 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants