-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migration for ingestion dashboard #6610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 708b3c5 in 1 minute and 36 seconds
More details
- Looked at
2791
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/migrate/ingestion_dashboard.go:1
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_Gj2YfvFIFiooHt7Z
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ce6aeb7 in 21 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/migrate/ingestion_dashboard.go:43
- Draft comment:
Ensure that the UUID is being set correctly elsewhere, as the linedash.Uuid = uuid.New().String()
was removed. This is crucial to avoid potential issues with duplicate or missing UUIDs. - Reason this comment was not posted:
Confidence changes required:50%
The UUID generation line was removed, but the UUID is still being set later in the code. This might be intentional if the UUID is being set elsewhere or if the dashboard object already has a UUID set. However, it's important to ensure that the UUID is being set correctly to avoid potential issues with duplicate or missing UUIDs.
Workflow ID: wflow_yVTH45wxoPTarBQn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Part of #5713 and https://github.com/SigNoz/engineering-pod/issues/2036
Important
Adds migration to create a new version of the ingestion dashboard if an old version exists and updates the old version's description to indicate deprecation.
migrateIngestionDashboard()
iningestion_dashboard.go
to check for existing ingestion dashboard and create a new version if it exists.Migrate()
inmigate.go
to executemigrateIngestionDashboard()
and log success or failure.GetDashboard()
inmodel.go
to update the description of the old ingestion dashboard to indicate deprecation.This description was created by for ce6aeb7. It will automatically update as commits are pushed.