Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration for ingestion dashboard #6610

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Dec 10, 2024

Part of #5713 and https://github.com/SigNoz/engineering-pod/issues/2036

  • Check if there is an ingestion dashboard, if yes creates a new v2 of ingestion dashboard.
  • When user loads ingestion dashboard, the description of the dashboard is updated

Important

Adds migration to create a new version of the ingestion dashboard if an old version exists and updates the old version's description to indicate deprecation.

  • Migration:
    • Adds migrateIngestionDashboard() in ingestion_dashboard.go to check for existing ingestion dashboard and create a new version if it exists.
    • Updates Migrate() in migate.go to execute migrateIngestionDashboard() and log success or failure.
  • Dashboard Update:
    • Modifies GetDashboard() in model.go to update the description of the old ingestion dashboard to indicate deprecation.

This description was created by Ellipsis for ce6aeb7. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Dec 10, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 708b3c5 in 1 minute and 36 seconds

More details
  • Looked at 2791 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/migrate/ingestion_dashboard.go:1
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_Gj2YfvFIFiooHt7Z


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on ce6aeb7 in 21 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/migrate/ingestion_dashboard.go:43
  • Draft comment:
    Ensure that the UUID is being set correctly elsewhere, as the line dash.Uuid = uuid.New().String() was removed. This is crucial to avoid potential issues with duplicate or missing UUIDs.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The UUID generation line was removed, but the UUID is still being set later in the code. This might be intentional if the UUID is being set elsewhere or if the dashboard object already has a UUID set. However, it's important to ensure that the UUID is being set correctly to avoid potential issues with duplicate or missing UUIDs.

Workflow ID: wflow_yVTH45wxoPTarBQn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

srikanthccv
srikanthccv previously approved these changes Dec 10, 2024
pkg/query-service/app/dashboards/model.go Outdated Show resolved Hide resolved
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@nityanandagohain nityanandagohain merged commit b25df66 into develop Dec 10, 2024
13 of 14 checks passed
@nityanandagohain nityanandagohain deleted the fix/ingestion-dashboard branch December 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants