Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tag attributes v2 table #6616

Merged
merged 6 commits into from
Dec 16, 2024
Merged

chore: use tag attributes v2 table #6616

merged 6 commits into from
Dec 16, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Dec 11, 2024

Summary

Part of SigNoz/signoz-otel-collector#467


Important

Update codebase to use distributed_tag_attributes_v2 table, reflecting schema changes and updating tests accordingly.

  • Behavior:
    • Update SQL queries in filter_suggestions.go and reader.go to use distributed_tag_attributes_v2 instead of distributed_tag_attributes.
    • Combine int64TagValue and float64TagValue into number_value in queries.
  • Configuration:
    • Rename constants in options.go to reflect new table names, e.g., defaultLogTagAttributeTableV2.
    • Update namespaceConfig and Options to use new table names.
  • Tests:
    • Update filter_suggestions_test.go to mock distributed_tag_attributes_v2 structure.
    • Adjust test expectations to align with new schema changes.

This description was created by Ellipsis for 867d5dd. It will automatically update as commits are pushed.

@github-actions github-actions bot added the chore label Dec 11, 2024
@srikanthccv srikanthccv marked this pull request as ready for review December 14, 2024 13:25
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 867d5dd in 30 seconds

More details
  • Looked at 406 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/tests/integration/filter_suggestions_test.go:216
  • Draft comment:
    Ensure that the regex pattern in ExpectQuery matches the updated table name distributed_tag_attributes_v2 consistently across all test cases.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test file has been updated to use the new table schema, which is consistent with the changes in the main code. This ensures that the tests are aligned with the new database schema changes.

Workflow ID: wflow_v7N6K9Ie2wLQpEXv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

srikanthccv added a commit to SigNoz/signoz-otel-collector that referenced this pull request Dec 16, 2024
@srikanthccv srikanthccv enabled auto-merge (squash) December 16, 2024 09:59
@srikanthccv srikanthccv merged commit e676602 into develop Dec 16, 2024
16 checks passed
@srikanthccv srikanthccv deleted the tag-attributes-v2 branch December 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants