-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use tag attributes v2 table #6616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 867d5dd in 30 seconds
More details
- Looked at
406
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pkg/query-service/tests/integration/filter_suggestions_test.go:216
- Draft comment:
Ensure that the regex pattern inExpectQuery
matches the updated table namedistributed_tag_attributes_v2
consistently across all test cases. - Reason this comment was not posted:
Confidence changes required:50%
The test file has been updated to use the new table schema, which is consistent with the changes in the main code. This ensures that the tests are aligned with the new database schema changes.
Workflow ID: wflow_v7N6K9Ie2wLQpEXv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
srikanthccv
added a commit
to SigNoz/signoz-otel-collector
that referenced
this pull request
Dec 16, 2024
nityanandagohain
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of SigNoz/signoz-otel-collector#467
Important
Update codebase to use
distributed_tag_attributes_v2
table, reflecting schema changes and updating tests accordingly.filter_suggestions.go
andreader.go
to usedistributed_tag_attributes_v2
instead ofdistributed_tag_attributes
.int64TagValue
andfloat64TagValue
intonumber_value
in queries.options.go
to reflect new table names, e.g.,defaultLogTagAttributeTableV2
.namespaceConfig
andOptions
to use new table names.filter_suggestions_test.go
to mockdistributed_tag_attributes_v2
structure.This description was created by for 867d5dd. It will automatically update as commits are pushed.