fix docker-compose setup

[edcohen08]

Background

Earlier today #836 was merged in but I think it needed an update to the readme for explanation and a tweak to the docker-compose.yml for clarity.

Changes

Added container_name: "redis-stack-server" on the redis container so it's easy to drop into the env.
Updated the readme with steps for running the docker-compose + redis.

Documentation

Updated the readme.

Test Plan

Have tested locally - this is the failure before changes -- LIGHT MODE WARNING

PR Quality Checklist

• My pull request is atomic and focuses on a single change.
• I have thoroughly tested my changes with multiple different prompts.
• I have considered potential risks and mitigations for my changes.
• I have documented my changes clearly and comprehensively.
• I have not snuck in any "extra" small tweaks changes

[mikekelly]

I don't understand why this is necessary? What is wrong with the default name of redis?

[tech3br]

@mikekelly I have same question.

[edcohen08]

Nothing wrong with it, I could've used redis but in my local testing the image doesn't spin up as redis it's like auto-gpt-redis-1. I could change this to redis but I think specifying a name is useful

[edcohen08]

Just so that there's something consistent people can put in their .env for the host

[edcohen08]

whoop my mistake, no need to specify the name. I at least think the readme update is useful and can modify the readme or close the pr

[aosan]

A specific name instead of a generic name helps avoid conflicts and/or confusion when multiple Redis containers may be running on the same host.

As a best practice, it's better to be specific than generic, especially when you can have OSS Redis, the standard engine; Redis Stack extension with builtin RedisInsight for Dev; and Redis Stack Server, the extension without RedisInsight for Production.

As convention, using the origin product name plus optional specific identifiers helps any new comers and avoids misunderstandings.

[mikekelly]

@aosan if you decide to go in that direction, you're still better off achieving this through the name of the service. Docker compose provides a network where the containers can address each other via their service name.

[nponeccop]

Not related to docker-compose. Revert.

[edcohen08]

whoops auto formatted the readme in the rebase

[mikekelly]

This service can be renamed to redis-stack-server and then there's is no need to specify the container_name

[p-i-]

Do we have consensus agreement from the discussion? Hard to see for me...

[mikekelly]

@p-i- The renaming of the container to make it more descriptive can be solved like so: #2202

[github-actions]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

[Pwuts]

The change to docker-compose.yml is not necessary (see #1843), and the docs already contain the proposed info. :)