Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repairs broken changes, Cleaned up Browsing, added switch to choose Selenium or Headless #1534

Closed
wants to merge 1 commit into from
Closed

Repairs broken changes, Cleaned up Browsing, added switch to choose Selenium or Headless #1534

wants to merge 1 commit into from

Commits on Apr 15, 2023

  1. * Combined summary.py web.py and browse.py because they were duplicat… 

    …ing each others efforts in many aspects.

* added a new config parameter in .env to control which kind of browser the user wants: headless or full Selenium with Chrome
* restored browse_website() to commands.py
* PR Significant-Gravitas#1397 introduced a working Selenium adapter, but inadvertently clobbered PR Significant-Gravitas#968, and replicated most of the stuff in browse.py, but based on an old version, without any merge conflicts. This is now rectified by moving Selenium code into browse.py, and reducing duplication as much as possible.
* there was a small typo, because an object reference was also returned along with the links in the link scraper.
* listed the PROs and CONs of each browser in the source code
    batyu committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a9fb5dd View commit details
    Browse the repository at this point in the history