Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browse_website by using a hidden browser instance #1744

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 62 additions & 22 deletions autogpt/commands/web_selenium.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,51 @@
FILE_DIR = Path(__file__).parent.parent
CFG = Config()

browser = None

def get_browser_instance() -> WebDriver:
"""Create or retrieve the browser instance."""
global browser
if not browser:
logging.getLogger("selenium").setLevel(logging.CRITICAL)

# For Chrome
chrome_options = ChromeOptions()
chrome_options.add_experimental_option("prefs", {
"download.default_directory": "/dev/null",
"download.prompt_for_download": False,
"download.directory_upgrade": True,
"plugins.always_open_pdf_externally": True
})

# For Firefox
firefox_options = FirefoxOptions()
firefox_options.set_preference("browser.download.folderList", 2)
firefox_options.set_preference("browser.download.manager.showWhenStarting", False)
firefox_options.set_preference("browser.download.dir", "/dev/null")
firefox_options.set_preference("browser.helperApps.neverAsk.saveToDisk", "application/pdf")
firefox_options.set_preference("pdfjs.disabled", True)

options_available = {'chrome': chrome_options, 'safari': SafariOptions, 'firefox': firefox_options}
options = options_available[CFG.selenium_web_browser]()
options.add_argument(
"user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.5615.49 Safari/537.36"
)
options.add_argument("--headless") # Add headless argument to hide the browser

if CFG.selenium_web_browser == "firefox":
browser = webdriver.Firefox(
executable_path=GeckoDriverManager().install(), options=options
)
elif CFG.selenium_web_browser == "safari":
browser = webdriver.Safari(options=options)
else:
browser = webdriver.Chrome(
executable_path=ChromeDriverManager().install(), options=options
)

return browser


def browse_website(url: str, question: str) -> Tuple[str, WebDriver]:
"""Browse a website and return the answer and links to the user
Expand All @@ -38,7 +83,7 @@ def browse_website(url: str, question: str) -> Tuple[str, WebDriver]:
# Limit links to 5
if len(links) > 5:
links = links[:5]
close_browser(driver)

return f"Answer gathered from website: {summary_text} \n \n Links: {links}", driver


Expand All @@ -51,27 +96,7 @@ def scrape_text_with_selenium(url: str) -> Tuple[WebDriver, str]:
Returns:
Tuple[WebDriver, str]: The webdriver and the text scraped from the website
"""
logging.getLogger("selenium").setLevel(logging.CRITICAL)

options_available = {'chrome': ChromeOptions, 'safari': SafariOptions, 'firefox': FirefoxOptions}

options = options_available[CFG.selenium_web_browser]()
options.add_argument(
"user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.5615.49 Safari/537.36"
)

if CFG.selenium_web_browser == "firefox":
driver = webdriver.Firefox(
executable_path=GeckoDriverManager().install(), options=options
)
elif CFG.selenium_web_browser == "safari":
# Requires a bit more setup on the users end
# See https://developer.apple.com/documentation/webkit/testing_with_webdriver_in_safari
driver = webdriver.Safari(options=options)
else:
driver = webdriver.Chrome(
executable_path=ChromeDriverManager().install(), options=options
)
driver = get_browser_instance()
driver.get(url)

WebDriverWait(driver, 10).until(
Expand Down Expand Up @@ -158,3 +183,18 @@ def add_header(driver: WebDriver) -> None:
None
"""
driver.execute_script(open(f"{FILE_DIR}/js/overlay.js", "r").read())


def close_browser(driver: WebDriver) -> None:
"""Close the browser

Args:
driver (WebDriver): The webdriver to close

Returns:
None
"""
global browser
if browser:
browser.quit()
browser = None