Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make headless Chrome more crash-resistent #2254

Closed
wants to merge 1 commit into from
Closed

Make headless Chrome more crash-resistent #2254

wants to merge 1 commit into from

Conversation

mrjdomingus
Copy link

Changes

  • Added two ChromeOptions to make headless browsing more robust (in particular for errors related tot DevToolsActivePort).

Documentation

Changes are inline documented.

Test Plan

Tested with several scenarios intended to exercise web browsing.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.

@Pwuts Pwuts added function: browse bug Something isn't working labels Apr 18, 2023
@Pwuts
Copy link
Member

Pwuts commented Apr 18, 2023

Closed as duplicate of #1473, #1984, #2086

@Pwuts Pwuts closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working function: browse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrjdomingus @Pwuts