Update docker-compose so it can run properly now #2966
Conversation
|
@Torantulino @BillSchumacher Please take a look |
|
partially duplicates #2923 |
| profiles: ["exclude-from-up"] | ||
|
|
||
| redis: | ||
| image: "redis/redis-stack-server:latest" | ||
| image: redis/redis-stack-server:latest | ||
| container_name: redis-stack-server |
There was a problem hiding this comment.
don't name containers if not necessary, naming containers can create conflicts with other containers of the same name
| #### Using docker-compose | ||
| In addition to the above changes in environment variables, change this one: | ||
| ```sh | ||
| REDIS_HOST=redis-stack-server |
There was a problem hiding this comment.
that would explain why you are naming the container. use the service name instead (redis), and docker will take care of the rest
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2966 +/- ##
==========================================
- Coverage 43.88% 37.64% -6.25%
==========================================
Files 60 60
Lines 2855 2856 +1
Branches 472 472
==========================================
- Hits 1253 1075 -178
- Misses 1498 1719 +221
+ Partials 104 62 -42 see 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
Closing as deprecated; this was already fixed in #1843 |
Background
Update the docker-compose it can run properly with Redis support.
Changes
Documentation
The change is small and can be understood by this pull request description.
Test Plan
Follow the step I described in the doc file change.
PR Quality Checklist