Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve for issue #9082: Marketplace - "Select All" doesn't work in Agent Dashboard #9247

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Ayush-Mittal10
Copy link

Changes πŸ—οΈ

I have done changes in AgentTable and AgentTableRow components present in autogpt_platform/frontend directory. The selectedAgents state is passed on to AgentTableRow component, so that when Select All is checked, individual check boxes also get checked.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description

For configuration changes:

  • .env.example was already compatible with my changes
  • docker-compose.yml was already compatible with my changes

@Ayush-Mittal10 Ayush-Mittal10 requested a review from a team as a code owner January 10, 2025 14:14
@Ayush-Mittal10 Ayush-Mittal10 requested review from ntindle and kcze and removed request for a team January 10, 2025 14:14
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Missing Event Handler

The checkbox input is missing an onChange handler to update the selectedAgents state when clicked. This makes the checkbox non-interactive and prevents proper state management.

<input
  type="checkbox"
  id={checkboxId}
  aria-label={`Select ${agentName}`}
  className="mr-4 h-5 w-5 rounded border-2 border-neutral-400 dark:border-neutral-600"
  checked={selectedAgents.has(agent_id)}
/>

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit b9b1b10
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67813097fce6bb00087f6bd6

Copy link

netlify bot commented Jan 10, 2025

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit b9b1b10
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67813097a7a662000852eaa6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants