[BUG FIX] Ensure deleted resources in major publications are removed from section resources [MER-2987] #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrensiegel
temporarily deployed
to
tokamak.oli.cmu.edu
GitHub Actions
Inactive
darrensiegel
temporarily deployed
to
heliotron.oli.cmu.edu
GitHub Actions
Inactive
eliknebel
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix here was to add a step before the final full hierarchy "refetch" which “cleans” the
childrenattribute of all section resource records, removing any SR id which no longer maps back to a currently published, non-deleted project resource.Because it was not possible to reproduce locally this bug, the plan to verify this bug fix is to test it out on a copy of the production DB running on Heliotron, before we merge this to 26.3
UPDATE: I verified that these changes fix the problem faced by the affected course section (https://heliotron.oli.cmu.edu/sections/test_cmu_98179_student_taught_/instructor_dashboard/manage) on a Feb 1 copy of Prod.