Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptors #73

Open
SimonEnsemble opened this issue May 18, 2018 · 2 comments
Open

descriptors #73

SimonEnsemble opened this issue May 18, 2018 · 2 comments
Assignees

Comments

@SimonEnsemble
Copy link
Owner

pore size, surface area, void fraction... what other descriptors? These are good to implement in case we want to build statistical models to rule out materials on the basis of quickly computed descriptors.

@mtap-research mtap-research self-assigned this May 19, 2018
@eahenle
Copy link
Collaborator

eahenle commented May 16, 2021

largest included and largest free sphere?

@SimonEnsemble
Copy link
Owner Author

would be great to have!
but to avoid making PM.jl more difficult to install than it already is, by giving it dependencies on Python packages... 😆, maybe better in a separate package that operates on an Xtal? actually, this should be in Xtals.jl if anything! and that already depends on a scipy package for the voronoi decomposition of local atomic environments, so maybe not much added complexity by making it depend on one more Python package for implementing largest included sphere?

@eahenle eahenle transferred this issue from SimonEnsemble/PorousMaterials.jl Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants