From b00b9e8522535a666fea609992fd99507f7b4f8a Mon Sep 17 00:00:00 2001
From: SimpleStation14 <130339894+SimpleStation14@users.noreply.github.com>
Date: Sat, 11 May 2024 20:09:51 -0700
Subject: [PATCH 01/46] Mirror: add more astro-grasses (#380)
## Mirror of PR #26381: [add more
astro-grasses](https://github.com/space-wizards/space-station-14/pull/26381)
from 
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `89235b9e1b91b32b3e55b364d46c79daabe199e9`
PR opened by 
IProduceWidgets at 2024-03-24 06:01:14 UTC
---
PR changed 7 files with 130 additions and 1 deletions.
The PR had the following labels:
- No C#
- Status: Needs Review
---
Original Body
>
>
>
> ## About the PR
>
> Ever fearful that their staff will manage to touch real grass,
NanoTrasen has put billions of spesos of work into developing the worlds
most life like astro-grasses. Yet still, with all the innovations made,
the glorious corporate overlords have deemed us worth of yet more
varieties of real fake grass. It almost feels like you're actually
outside!
>
>
> ## Why / Balance
>
> To celebrate the server's remarkable uptime metrics.
>
> ## Technical details
>
>
> ## Media
>
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
>
> **Changelog**
>
>
>
> :cl:
> - add: More varieties of astro-grass are now available.
> - tweak: Astro-grass must now be cut instead of pried.
Original Body
>
>
>
> ## About the PR
>
> fixed #25519 the tagging for the captain's laser glass box.
>
> ## Why / Balance
>
>
> ## Technical details
>
>
> ## Media
>
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
>
> **Changelog**
>
>
>
> :cl:
> - fix: The captain can now return his laser to the glass display box.
Emisse at
2024-01-09 07:36:29 UTC
---
PR changed 17 files with 4009 additions and 67 deletions.
The PR had the following labels:
---
Original Body
> also for sloth when he gets to it
>
> Requires https://github.com/space-wizards/RobustToolbox/pull/4980
IamVelcroboy
at 2024-03-16 20:59:22 UTC
---
PR changed 1 files with 1 additions and 1 deletions.
The PR had the following labels:
- No C#
---
Original Body
> ## About the PR
> Title
>
> ## Why / Balance
> Frequently requested feature/QoL
>
> ## Technical details
> n/a
>
> ## Media
> n/a
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes in-game, **or** this PR does not require an in-game showcase
>
> ## Breaking changes
> n/a
>
> **Changelog**
> :cl: Velcroboy
> - tweak: Tweaked gas canisters to pass through cargo flaps.
Crotalus at 2024-03-12 22:44:16
UTC
---
PR changed 1 files with 34 additions and 16 deletions.
The PR had the following labels:
- Status: Needs Review
---
Original Body
> ## About the PR
> Sort the agents by success rate in the end game summary
> ## Why / Balance
> Fame and glory to the robust
>
> **Changelog**
> :cl:
> - tweak: Sort agents by success rate in end game summary
>
>
DoutorWhite at
2024-03-12 07:00:06 UTC
---
PR changed 8 files with 78 additions and 13 deletions.
The PR had the following labels:
- Changes: Sprites
- Status: Awaiting Changes
---
Original Body
> ## About the PR
>
> There are some changes to the Medical Hud interface: The icon has been
changed and now there is one for each mob state, making it easier to
recognize whether the mob is rotting, dead or crit.
>
> ## Why / Balance
>
> It's more visually pleasing and helps with discerning mob states.
>
> ## Technical details
>
> There is a decision structure for determining which icon is
appropriate for the mob's state. It's the only relevant code change.
>
> ## Media
>
> 
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
>
> **Changelog**
>
> :cl:
> - add: Introduce new health status icons.
> - tweak: Enhance the Medical HUD to display the health status of
players and mobs using the newly added icons.
Dutch-VanDerLinde at 2024-02-20 00:35:08 UTC
---
PR changed 1 files with 15 additions and 4 deletions.
The PR had the following labels:
- No C#
- Status: Needs Review
---
Original Body
>
>
>
> ## About the PR
> traitor syndie reinforcements get the autotraitor component, like
traitor syndie monkies
>
> ## Why / Balance
> syndie monkies can see the codewords, so why cant the more expensive
human reinforcement see the codewords aswell?
> this also makes it so they are listed as an antag with admin vision
>
>
> ## Technical details
> made syndicate base for human reinforcement
>
>
> gives traitor reinforcement the autotraitor component
>
> ## Media
>
https://github.com/space-wizards/space-station-14/assets/45323883/5ada01f9-d098-46e5-baea-487e2215ba58
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> no
>
> **Changelog**
> no
>
LordCarve at
2024-03-17 20:05:08 UTC
---
PR changed 13 files with 43 additions and 82 deletions.
The PR had the following labels:
- Status: Needs Review
---
Original Body
>
>
>
> ## About the PR
>
> Log things via `Log` with generated sawmill name rather than an
explicitly set one for all Content `EntitySystem`s, except the ones with
`Rule`s. In all cases the explicit `_sawmill` was redundant.
>
> ## Why / Balance
>
> - Bringing consistency to logs (all logs originating from
`EntitySystem` should be recognizible in the logs `system.something`).
> - Logs' sawmills match system class name to assist with debugging.
> - Less likelihood of someone building a new `EntitySystem` to
copy-paste the unnecessary `_sawmill` and instaed use the appropriate
inherited `Log` instead.
>
> ## Technical details
>
> This addresses **_just_** `Content`'s `EntitySystem`s.
>
> `GameRuleSystem` **and all classes inheriting from it are excluded.**
I want to include both the calling system name and the rule name in the
sawmill name - this however requires engine changes. I thus opted to cut
out that part and made this a `Content`-only PR.
>
> Also, even with the rule changes, the `GameRule`s themselves will be
excluded pending antag refactor, because currently they are a _hot-hot_
mess and I'm sure it's preferable by everyone for me to wait for it to
cool down before introducing merge conflicts unnecessarily.
>
> Log Sawmill changes:
> **System class | current master sawmill | this PR's sawmill**
> `VaporSystem.cs`: `vapor` -> `system.vapor`
> `DeviceListSystem.cs`: `devicelist` -> `system.device_list`
> `ForensicScannerSystem.cs`: `forensic.scanner` ->
`system.forensic_scanner`
> `MappingSystem.cs`: `autosave` -> `system.mapping`
> `MechSystem.cs`: `mech` -> `system.mech`
> `LagCompensationSystem.cs`: `lagcomp` -> `system.lag_compensation`
> `NpcFactionSystem.cs`: `faction` -> `system.npc_faction`
> `EmergencyShuttleSystem.cs`: `shuttle.emergency` ->
`system.emergency_shuttle`
> `EventManagerSystem.cs`: `events` -> `system.event_manager`
> `VendingMachineSystem.cs`: `vending` -> `system.vending_machine`
> `SharedAnomalySystem.cs`: `anomaly` -> `system.anomaly`
> `SharedDeviceLinkSystem.cs`: `devicelink` -> `system.device_link`
> `ThirstSystem.cs`: `thirst` -> `system.thirst`
>
> Manually tested most (all that I had doubts about) and confirmed that
`LagCompensationSystem`'s `Log.Level` is getting correctly set like
this.
>
> ## Media
>
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
> Log sawmill name changes. Any analyzers/other software that processes
logs needs to be adjusted to new sawmills. Full list of changes in PR -
section Technical details.