Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites Service Uniforms & Adds Rolled Sleeve Variants #1021

Merged
merged 31 commits into from
Oct 10, 2024

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Oct 8, 2024

Description

This PR resprites the service uniforms with the Aurora variants, as well as doing minor yaml cleanup for the base_clothinguniforms.yml

Aurora has 2-3 variants for service staff; based on which company they're associated with. So far I've just picked the Nanotrasen variant, because SS14 uses Nanotrasen.

My question is:
A) Should I port the extra uniforms and stick them in loadouts, for variety & drip?
i) Should I keep the company names on these uniforms if I port them, or should I keep it
Nanotrasen?

This PR also removes in-hand variants; they're not supported in aurora and it's not critical game info to see someone carrying a shirt & pants.

This PR similarly removes the animal variants; the Vox PR should have displacement maps to support it.


TODO

  • Bartender Jumpsuit

  • Bartender Vest

  • Bartender Hat

  • Janitor Jumpsuit

  • Chef Jumpsuit

  • Chef Freezer Jacket

  • Chef Hat

  • Botanist Uniform

  • Librarian Uniform
    ^ Librarian Jumpsuit has been added with four extra variants, some corporations who do not employ Librarians still have jumpsuit sprites.


Media

Nanotrasen Bartender

image
image
image
image

Nanotrasen Chef

image
image
image
image

Nanotrasen Botanist

image
image
image
image

Nanotrasen Janitor

image
image
image
image

Nanotrasen Librarian

image
image
image
image


Changelog

🆑 DangerRevolution

  • add: Resprited basic Service Staff uniforms
  • add: Add rolled sleeve variants for Service Staff uniforms.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Oct 8, 2024
@SimpleStation14 SimpleStation14 changed the title Resprites Service Uniforms? Adds rolled sleeve variants? Resprites Service Uniforms? Adds Rolled Sleeve Variants? Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

RSI Diff Bot; head commit 61f4ed2 merging into 3ae1cf1
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/chefhat_idris.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/Head/Hats/chefhat_nt.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/Head/Hats/chefhat_orion.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/Head/Hats/flatcap_idris.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/Head/Hats/flatcap_nt.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/Head/Hats/flatcap_orion.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Clothing/OuterClothing/Misc/chef_idris.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/OuterClothing/Misc/chef_nt.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/OuterClothing/Misc/chef_orion.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/OuterClothing/Vests/vest_idris.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/OuterClothing/Vests/vest_nt.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/OuterClothing/Vests/vest_orion.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender_idris.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender_nt.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender_orion.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/chef_idris.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/chef_nt.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/chef_orion.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/hydro_idris.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/hydro_nt.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/hydro_orion.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/janitor_idris.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/janitor_nt.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/janitor_orion.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_heph.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_idris.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_nt.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_orion.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_pmcg.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_zav.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/librarian_zeng.rsi

State Old New Status
equipped-INNERCLOTHING Added
flipped-equipped-INNERCLOTHING Added
icon Added
icon_flipped Added

Edit: diff updated after 61f4ed2

@DangerRevolution
Copy link
Contributor Author

Media attached; need thoughts on:

My question is:
A) Should I port the extra uniforms and stick them in loadouts, for variety & drip?
i) Should I keep the company names on these uniforms if I port them, or should I keep it
Nanotrasen?

@VMSolidus
Copy link
Member

VMSolidus commented Oct 8, 2024

  1. Should I port the extra uniforms and stick them in loadouts, for variety & Drip?

ABSOLUTELY YES.

  1. Should I keep the company names on these uniforms if I port them, or should I keep it Nanotrasen?

You actually should keep the company names on the uniforms. Me and Death are cooking our own take on the Records page with Loadout Integrations, and one of the options is a button for selecting "Employment Status", between either working for Nanotrasen, or as a Contractor from another corporation(Selected from YML Prototypes), and we wanted Loadout integrations with this. For example picking Hephaeustus Heavy Industries as a Contractor status locks a character to Engineering roles, but now their engineering loadouts allow them to pick up Hephaeustus equipment variants.

@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Oct 8, 2024

@VMSolidus Second problem is that the majority of these uniforms do not have jumpskirt variants, I'm more than happy to throw the tag on so Harpies can wear them though.

With the Vox rework maybe you could use displacement maps to make skirt / harpie variants but 🤷

@VMSolidus
Copy link
Member

@VMSolidus Second problem is that the majority of these uniforms do not have jumpskirt variants, I'm more than happy to throw the tag on so Harpies can wear them though.

With the Vox rework maybe you could use displacement maps to make skirt / harpie variants but 🤷

We'll keep the tag off. Wizmerge is getting Displacement maps, so I can try to get that setup for Harpies(Although I am incredibly distasteful of it)

@DangerRevolution
Copy link
Contributor Author

Most likely worth considering adding tags to hide hair to some of these; I'm not sure if they look this bad in vanilla, but a lot of hairstyles just overflow the helmets.

@DangerRevolution DangerRevolution changed the title Resprites Service Uniforms? Adds Rolled Sleeve Variants? resprites service uniforms & adds rolled sleeve variants Oct 8, 2024
@SimpleStation14 SimpleStation14 changed the title resprites service uniforms & adds rolled sleeve variants Resprites Service Uniforms & Adds Rolled Sleeve Variants Oct 8, 2024
@DangerRevolution
Copy link
Contributor Author

Barebones ready for review; I'll slowly chip away at the common role items that aren't directly job related (such as Aprons or Shoes) if Aurora has fitting sprites.

Main thing missing is the Botany headband; however I either need to completely remove flipping from it, find a sprite, or draw my own.

@DangerRevolution DangerRevolution marked this pull request as ready for review October 8, 2024 22:58
@VMSolidus
Copy link
Member

I think I would strongly prefer if this PR was adding new clothing items using said textures, rather than fully replacing pre-existing clothing items. That'll go over with the players a hell of a lot better.

image

@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Oct 8, 2024

I think I would strongly prefer if this PR was adding new clothing items using said textures, rather than fully replacing pre-existing clothing items. That'll go over with the players a hell of a lot better.

I wasn't aware EE hosted servers, but I can do that

@DangerRevolution DangerRevolution marked this pull request as draft October 8, 2024 23:03
@DangerRevolution
Copy link
Contributor Author

readded wizden variants of uniforms @VMSolidus

@DangerRevolution DangerRevolution marked this pull request as ready for review October 8, 2024 23:25
@VMSolidus VMSolidus merged commit 00d83ef into Simple-Station:master Oct 10, 2024
15 checks passed
SimpleStation14 added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants