Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Criminal record hud icons #144

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25192: Criminal record hud icons from space-wizards space-wizards/space-station-14

60b9d89e4dbdd8aaad4992a105628297d9480617

PR opened by Arendian at 2024-02-13 19:39:59 UTC
PR merged by web-flow at 2024-03-11 03:12:52 UTC


PR changed 19 files with 230 additions and 40 deletions.

The PR had the following labels:

  • Changes: UI
  • Changes: Sprites
  • Status: Needs Review

Original Body

About the PR

Added three more statuses to the criminal record console: Paroled, Suspect, Discharged.
Entities now have a hud icon based on the criminal record linked to the name they are currently showing.
If "Urist McHands" is wanted, anyone that currently shows as being "Urist McHands", even when their real name is not Urist McHands, will show the relevant hud icon to entities wearing a security hud. If Urist McHands is disguised as someone without a criminal record or has no name(middle-aged captain man etc.), they won't show an icon.

Why / Balance

Icons showing on sechuds will make sechuds more usefull, it will (hopefully) improve security coordination by allowing officers to more easily see who they need to keep track of.
It also gives warden something extra to do.

Technical details

When a criminal record is changed, every entity with an IdentityComponent will have their name checked to see if it equals the name of the changed criminal record, if it's equal the person will get the CriminalRecordComponent which holds the icon that needs to be shown on the entity.
If a criminal record is removed, the CriminalRecordComponent will be removed from all entities that currently have the visible name associated with the criminal record.

If an entity changes identity, all criminal records will be searched to see if the name has a criminal record attached to it. If the name has a record attached to it, the entity will get the CriminalRecordComponent and the corresponding criminal record hud icon until they change their identity again or the criminal record gets removed.

Media

CriminalRecordHud.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Dygon

  • add: The following criminal record statuses have been added: Suspect, Discharged, Paroled.
  • add: Security huds now show an icon on entities that have a visible name linked to a criminal record.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Copy link
Contributor

RSI Diff Bot; head commit 8b8fcd4 merging into 3bf08c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/security_icons.rsi

State Old New Status
hud_discharged Added
hud_incarcerated Added
hud_paroled Added
hud_suspected Added
hud_wanted Added

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:17
@VMSolidus VMSolidus enabled auto-merge (squash) May 4, 2024 23:38
@VMSolidus VMSolidus merged commit 375b1c0 into Simple-Station:master May 4, 2024
22 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants