Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Add logs to recycler gibbing and broadcasting. #156

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26008: Add logs to recycler gibbing and broadcasting. from space-wizards space-wizards/space-station-14

2b8415b378c181fd0222cdf7f4d005a70ebe8044

PR opened by nikthechampiongr at 2024-03-11 18:01:29 UTC
PR merged by web-flow at 2024-03-12 10:57:05 UTC


PR changed 3 files with 8 additions and 0 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

fixes #25556
fixes #25037

About the PR

This just adds logs for broadcasting and getting gibbed by a recycler.

Why / Balance

Me admin. Me want this logs. Me beat logs with rock if I no know why passenger gibbed or who put the nword on all the monitors in the station.

Technical details

The broadcast log uses the new DeviceNetwork log because I can find no other appropriate log type. The closest is Chat which announcements use but this makes no sense.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑
ADMIN:

  • add: Recyclers now leave logs when they gib people.
  • add: People sending a broadcast in the communications console now leave logs.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:32
@VMSolidus VMSolidus enabled auto-merge (squash) May 4, 2024 23:57
@VMSolidus VMSolidus merged commit a751152 into Simple-Station:master May 4, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants