Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Attempt at a more noticably whispered bubble #171

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25602: Attempt at a more noticably whispered bubble from space-wizards space-wizards/space-station-14

4f698a6e0d74d28713e2dabbfb20969477538e11

PR opened by maylokana at 2024-02-26 14:44:39 UTC
PR merged by web-flow at 2024-03-13 08:03:32 UTC


PR changed 2 files with 10 additions and 1 deletions.

The PR had the following labels:


Original Body

About the PR

Added a bigger difference between talk bubbles and whisper bubbles

Why / Balance

Because (at least for me) it was a little difficult to see when someone was whispering vs when someone was normally speaking. There is a small change between borders, but it is hard to tell between a lot of bubbles at once

Technical details

There is probably a better way to do this
One new line in SpeechBubble checking if speechStyleClass is "whisperBox", if true manually formats bubbleContent

Media

Screenshot showing new differences between the two bubbles
hellotest

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None that I know of

Changelog

🆑

  • tweak: Italicized whisper bubbles

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's visible enough as is, but why not

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 00:37
@VMSolidus VMSolidus merged commit 3c06ff1 into Simple-Station:master May 12, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants