-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "AME buff" #20
Revert "AME buff" #20
Conversation
This reverts commit e271a5d.
This is just wrong. This was because theres issues with battery values and its waiting on tweaks that are currently pending PRs. Reverting this change without fixing the main power issue will just force engineers to use power sources that'll cause all the lights to flicker. |
Is it this one? The one that fixes battery issues? space-wizards/space-station-14#25898 |
One of them yes. I dont think anything has been done for all the other values that are fucked |
So I think I can add some context here, and why this doesn't actually matter for DeltaV outside of one very specific map that has an easily fixed issue. The underlying reason why this change was made was for one very specific Wizden map, called Core. Core, famously has a Singularity engine in the exact center of the station. The underlying reason this change was done was that engineers were consistently failing to setup the singularity correctly, in the time limit alotted to them by the station's intentionally undersized AME. However, because the entire station was made around Engineering, it would take dozens of hours of mapping work just to expand the AME room to include a fullsize AME, because literally the entire map would need to be altered to accomodate such a change. Yes, there is also a bug with SMES. If the total amount of SMES outputs is not great enough to supply the Load required by the station, it causes a brownout issue where the lights flicker. This bug is actually present on Edge station, and is fairly easily fixed with some slight modification to wiring. However that is also itself a mapper issue, not a code issue. For the most part the DeltaV maps did not actually require this change, since we did not have the underlying map issue that Wizden had that justified it. Our maps were designed from the get go with a full size AME, every one of them. Undoing this change is justified, since it was irrelevant to the DV codebase in the first place. And it's irrelevant to this codebase as well. |
It sounds to me like this is a quick fix to a genuine problem that only cropped up in specific circumstances. If we don't foresee those circumstances arising and we feel the fix causes issues elsewhere, it is perfectly valid to undo it. We should, however, keep in the mind the real underlying problem that lead to this fix in the first place and remember that it needs to be dealt with. |
Upstream Merge 6/7/2024
…ommon Fix Human Sol-Common
This reverts commit e271a5d.
Description
The AME buff made by Wizden is a bandaid solution to Engineers refusing / being inept at / getting killed while setting up the round's power source, that being Singulo or AME or Tesla. As a result, the station quickly runs out of power and everyone suffers as their AME rooms are quite small, due to the philosophy of AME being a placeholder.
As a result, they cranked up the AME power so it can handle the station while Engineers set up power.
Delta stations, and quite literally any non-Wizden station don't give the antimatter engine a broom closet to be set up in so this is never an issue. As a result, this update does nothing for us but make AME so OP that other power is unnecessary.
TODO:
Wait for:
Changelog
🆑 DangerRevolution