Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Minor Fixes from WizDen / merges up to 20th march #24

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Mar 20, 2024

Description

Look through the commits, the names are self-explanatory and shouldn't be controversial hence they're in one lump PR.

Skipped

March 16th - end of March 20th
skipped engine update
skipped detective stamp
skipped explosion-proof backpack in the uplink
skipped less fish in maints
skipped store refunds
skipped anomaly decay logs
skipped new wooden furniture
skipped syndicate monkey TC lowering --> I want to fuck with TC costs personally
skipped loneops TC 40-->60
skipped loneops minplayers --> 20
skipped Code cleanup: Dirty(Comp) (#26238)

Tayrtahn and others added 7 commits March 20, 2024 11:12
* Fix tranq rounds injecting when reflected

* Cleanup using directives

* Remove FixtureId from component
Co-authored-by: deltanedas <@deltanedas:kde.org>
pro

Co-authored-by: deltanedas <@deltanedas:kde.org>
* created and added CarpetSBlue tag

* reverting unnecessary de-indentation

* Update carpets.yml
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Mar 20, 2024
@DangerRevolution DangerRevolution marked this pull request as ready for review March 20, 2024 11:37
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title [Port] Various minor Wizden fixes & optimisations Various Minor Fixes from WizDen Mar 20, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT added Type: Port Brings something to here from another codebase Status: Requires This requires something else to be done before being resolved labels Mar 20, 2024
Plykiya and others added 17 commits March 21, 2024 21:23
* Round start Ion storms

* five

* Update Resources/Prototypes/GameRules/events.yml

---------

Co-authored-by: Plykiya <plykiya@protonmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
* Fixes target hand check when no hands were needed.

* Adds missing CanStripX checks.

* Whitespace.

* Fixed bad math causing instant strips.
Fix anomaly decay logs (#26122)
Fix anomaly decay logs (#26122)
* inital

* Update animals.yml
…ps (#26193)

Co-authored-by: Jeff <velcroboy333@hotmail.com>
* Kill the static InRangeUnOccluded

* Adjusted 4 more EntitySystems that were missed.
Use Log with generated sawmill name rather than explicitly named one for all non rule-based Content EntitySystems.
The math for our pressure damage (barotrauma) system is directly taken from TG. The constants are the same and the math is almost the same. However there are two errors.

1. Pressure damage started being applied within the WARNING bounds, rather than the HAZARD bounds. This means you started taking low pressure damage at 50 kPa instead of the intended 20 kPa, and also the HUD icon didn't show "danger" like it should even if you were already taking damage.

2. The calculations for high pressure damage were wrong. These are supposed to be linearly scaled, but the function was wrong so the scaling didn't actually work properly (especially when considering the fixed bounds above). This appears to be the case because the function was taken from an incorrect comment in the original source, rather than the real math.

Both of these issues are now fixed to match the TG behavior. Note that this somewhat nerfs pressure damage in non-extreme circumstances. e.g. a room at 40 kPa now gives NO pressure damage, whereas previously it would do full space damage.

The description of the pressure alerts is wrong for "low" severity, but I can't be arsed to fix that right now. Alerts don't have a way to change the description depending on severity...
If a room's pressure drops it can become unbreathable long before people start taking pressure damage, and so also long before the air alarm starts reporting a danger state. I've increased the values so that the air alarm should show danger if the pressure becomes so low as to be unbreathable.
Copy link
Contributor

github-actions bot commented Mar 21, 2024

RSI Diff Bot; head commit 818e8d1 merging into f82ad18
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Fluids/puddle.rsi

State Old New Status
splat10 Modified
splat11 Modified
splat12 Modified
splat13 Modified
splat14 Modified
splat3 Modified
splat5 Modified
splat6 Modified
splat7 Modified
splat9 Modified

Resources/Textures/Interface/Misc/health_icons.rsi

State Old New Status
Fine Modified
Critical Added
Dead Added
Rotting Added

Resources/Textures/Objects/Fun/spraycans.rsi

State Old New Status
spray_cap Removed
clown-inhand-left Added
clown-inhand-right Added
spray-inhand-left Added
spray-inhand-right Added

Resources/Textures/Interface/Misc/job_icons.rsi

State Old New Status
InitialInfected Added

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
secure_icon Added

Resources/Textures/Structures/Storage/wall_locker.rsi

State Old New Status
generic_icon Added

Edit: diff updated after 818e8d1

keronshb and others added 11 commits March 21, 2024 22:11
Removes else that accidentally enables refunds
* Fix build

- Fixes a couple paint things that were broken.

* wat
* throw miss

* event

* whoops

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* fix popup duplication

* Separate cancellable event

* no popup, no problem

* remove leftover stuff

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Wire layouts manually navigate the inheritance hierarchy, but the data fields on the prototypes were also automatically inherited already. This meant that inheriting a wire layout prototype and changing nothing would cause the wires to be duplicated unless they were manually modified on top.

Fix is easy: just disable inheritance on the data fields.

Also, integration test for it.
* add per-department wire layouts

* fix science/research inconsistency

* fix wireLayout inheritance

* science is no longer security

* Security doors back to normal wire count

* implement proper wire inheritance

* revert WiresSystem.cs fix
* Pizza is not a fruit

* Also the slice

* Let the lizards still eat pizza
@DangerRevolution DangerRevolution changed the title Various Minor Fixes from WizDen Various Minor Fixes from WizDen / merges up to 20th march Mar 21, 2024
@DangerRevolution DangerRevolution marked this pull request as draft March 21, 2024 22:26
@DangerRevolution
Copy link
Contributor Author

Engine is fucked somehow, I thought I updated it but not really sure ig

@DangerRevolution DangerRevolution marked this pull request as ready for review March 21, 2024 22:44
@DangerRevolution DangerRevolution marked this pull request as draft March 21, 2024 22:49
@DangerRevolution
Copy link
Contributor Author

Gonna set this to draft because I've fucked around and found out, hopefully someone somewhere fixes this into working. I am kinda out of my depth. I should be doing work anyways.

@DangerRevolution DangerRevolution marked this pull request as ready for review March 23, 2024 18:20
@DangerRevolution DangerRevolution deleted the wizden-cherrypick-2 branch March 23, 2024 22:21
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Requires This requires something else to be done before being resolved Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.