Mirror: Fix Recycled Containers Deleting Items Inside Them

[SimpleStation14]

Mirror of PR #26045: Fix recycled containers deleting items inside them from space-wizards/space-station-14

d7484ae9f57477a5ec5c575e3077aa94c0564db6

PR opened by SlamBamActionman at 2024-03-12 16:16:42 UTC

---

PR changed 2 files with 19 additions and 1 deletions.

The PR had the following labels:

• Status: Awaiting Changes

---

Original Body

About the PR

Right now you can delete any item that fits in a survival box by placing it inside of one and then recycling the box in a Recycler/Material Reclaimer. This PR fixes this by dumping out any item inside containers.

• For Reclaimers, any recyclable items inside the container get placed on top of the Reclaimer.
• For Recyclers, any recyclable items inside the container get recursively recycled as well.

Why / Balance

I doubt it's intended behavior to be able to effectively delete any item that fits in a box. Also ensures a recycled box provides the correct amount of material as its contents also get recycled.

Technical details

When trying to recycle, once all checks are passed it iterates through the object's containers if it has any and dumps out any items onto the machine doing the recycling.

Media

The result of recycling a survival box in a Recycler/Reclaimer.

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

• fix: Recyclers no longer delete items stored inside of recycled entities.

[DangerRevolution]

think this messed with Nyano code, this should also be tested to NOT recycle Felinids

[VMSolidus]

Felinids shoved into either machine via duffel bag just get spat out by the machine.

Resolved