Mirror: Fix some invalid damage types

[SimpleStation14]

Mirror of PR #26295: Fix some invalid damage types from space-wizards/space-station-14

b34777177ca2b379c67fb5d0d117f95b8809f43e

PR opened by Tayrtahn at 2024-03-20 19:10:30 UTC

---

PR changed 7 files with 8 additions and 8 deletions.

The PR had the following labels:

• No C#

---

Original Body

About the PR

Corrected the names of a few damage types in various DamageTypeSpecifiers.

Why / Balance

This might have some balance implications, as a few things will be doing damage they didn't previously.

• Space bears now do some blunt damage along with the usual slash.
• The Throngler does massive structural damage.
• RobustHarvest does a little heat damage to non-plants.
• Fresium does a bit of negative heat damage.

All of these effects were presumably intended by the authors of various PRs that added them, but were nonfunctional due to using an invalid name. If it's decided that these additional damage types are undesired, they should just be removed instead of relying on a bug to ignore them.

I also changed a few entries that were doing 0 damage in invalid types. They now do 0 damage in valid types, for whatever that's worth.

Technical details

I haven't figured out how to get the YAML linter to properly catch these issues, but I got it to spit out a list of these errors while messing around with it, so I figured I'd go ahead and fix them.

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog