Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Hide empty marking categories in the markings picker #324

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26377: Hide empty marking categories in the markings picker from space-wizards space-wizards/space-station-14

4790ccba19c1f63f21a2aa57fe4525587c119d9c

PR opened by DrSmugleaf at 2024-03-24 03:49:01 UTC


PR changed 1 files with 33 additions and 11 deletions.

The PR had the following labels:

  • Changes: UI

Original Body

About the PR

Updates when something about the character is changed.
This helps not gaslight me about which markings a species has available, and also slime person players are faced with the hard truth that they barely have any.

Media

Content.Client_wsIxHI5VO9.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • tweak: Empty marking categories are now hidden in the markings picker.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@DangerRevolution
Copy link
Contributor

should be tested with Delta-exclusive markings

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@FoxxoTrystan
Copy link
Member

PR is working and with DeltaV Species, Run the tests!

image
image

@VMSolidus VMSolidus marked this pull request as ready for review May 13, 2024 17:50
@DangerRevolution DangerRevolution enabled auto-merge (squash) May 13, 2024 17:53
@DangerRevolution DangerRevolution merged commit 2079364 into Simple-Station:master May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants