Trait Points #434
Merged
Trait Points #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I told you those loadout prototype changes were relevant
DEATHB4DEFEAT
added
Priority: 2-High
github-actions
bot
added
Changes: C#
75 tasks
…ngines into trait-points
make categories easier to click I don't want to sort them rn
DangerRevolution
approved these changes
Jun 20, 2024
DEATHB4DEFEAT
added
Status: Do Not Merge
VMSolidus
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
I'm satisfied with this system now. My only complaint is something out of scope of this PR, but is something a ton of people are going to solve pretty shortly once we've merged this, myself included. That is, the game outright lacks positive traits for people to spend their trait points on. The entire list is all negative or neutral traits.
SimpleStation14
added a commit
that referenced
this pull request
Jun 20, 2024
|
Yea I was with him in a voice call doing what he needed done. :) |
Labels are a lie.. 1984 |
DEATHB4DEFEAT
removed
Status: Do Not Merge
VMSolidus
added a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Jun 21, 2024
Some improvements to loadouts too. --- - [x] Points logic - [x] Server-side validation - [x] Categorize traits - [x] Assign points to traits - [x] Header costs - [x] Sort entries - [x] Max traits - [x] Communicate max traits - [x] Point bar - [x] Group exclusivity - Black outline on text - [x] Fix existing component whitelists --- <details><summary><h1>Media</h1></summary> <p>     </p> </details> --- :cl: - add: Added trait points - add: Added categories for traits --------- Co-authored-by: VMSolidus <evilexecutive@gmail.com>
VMSolidus
pushed a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some improvements to loadouts too.
TODO
Media
Accurate except for small details
Something to note:
Changelog
🆑