Mirror 26441: Fix atmos NaN error

[SimpleStation14]

Mirror of PR #26441: Fix atmos NaN error from space-wizards/space-station-14

fdb4a61487db9fc67714c913832427063abdea42

PR opened by ElectroJr at 2024-03-26 04:27:08 UTC - merged at 2024-03-26 04:44:56 UTC

---

PR changed 16 files with 43 additions and 25 deletions.

The PR had the following labels:

• Status: Needs Review

---

Original Body

• Fixes a bug I introduced in #22521 that caused the temperature to be set to NaN. I don't know for sure, but I assume this is causing the current atmos issues
• Fixes FixVacuum not working after #22521
• Removes some redundant yaml that was setting FixVacuum to its default value

🆑

• fix: Fixed an atmos bug, which was (probably) causing atmospherics on the station to behave incorrectly.

[Pspritechologist]

What is this doing here?? 🤨

[VMSolidus]

I'm genuinely not sure why it has to diff the entire entity, but the only thing being removed is the Airtight fixVacuum argument.

[Pspritechologist]

Turning on 'hide whitespace' removes the odd changes, so just some funky whitespace stuff. Consider redoing the important changes so we don't have the ugly diff, merge otherwise.

[VMSolidus]

I need this for the next set of Engine updates.

[VMSolidus]

I'm genuinely not sure why it has to diff the entire entity, but the only thing being removed is the Airtight fixVacuum argument.

[Pspritechologist]

Turning on 'hide whitespace' removes the odd changes, so just some funky whitespace stuff. Consider redoing the important changes so we don't have the ugly diff, merge otherwise.