Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Loadouts Breaking when You Spend All Your Points #506

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

WarMechanic
Copy link
Contributor

@WarMechanic WarMechanic commented Jul 2, 2024

Description

Self explanatory

P.S. i genuinely dont know what the fuck i did, who wrote this?

TODO

  • Fix shit

Media

https://youtu.be/hbJbd5SgZ54

Changelog

🆑

  • fix: Fixed loadouts becoming uneditable after spending all your points

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Jul 2, 2024
@SimpleStation14 SimpleStation14 changed the title Fix loadouts breaking when you spend all your points Fix Loadouts Breaking when You Spend All Your Points Jul 2, 2024
@WarMechanic
Copy link
Contributor Author

im going to leave this as a draft for now because im really worried that this shouldnt be working, but it does

@WarMechanic WarMechanic marked this pull request as ready for review July 2, 2024 06:58
@WarMechanic
Copy link
Contributor Author

nah im not going to edit my database to see what happens when someone has negative points.

when the item you want to buy ends you with less than 0 points then you cant buy it which is basically fixed.

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jul 2, 2024
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified in testing that this does infact fix Issue #498

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigma

@DangerRevolution DangerRevolution merged commit 606a28d into Simple-Station:master Jul 2, 2024
22 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 2, 2024
@WarMechanic WarMechanic deleted the fixloadouts branch July 2, 2024 07:21
@DEATHB4DEFEAT
Copy link
Member

Oh, that's why, makes sense how I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants