Fix Clothing Quick-Equip #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently doing the same to TryUnequip fixes quick swap too Nevermind, it does not. |
|
Right, I decided to just make the clothing system skip pocket slots while quick equipping. It's actually stupid that pockets were considered valid slots for this action, because for example if you were to hold and ID card and press Z, it would swap the item in your pocket with that ID, which had personally pissed me off before. So this should kill two bugs with one stone. |
DangerRevolution
approved these changes
Jul 3, 2024
VMSolidus
approved these changes
Jul 3, 2024
SimpleStation14
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, ClothingSystem.TryEquip would return false if there's a do-after to equip the clothing. This had caused all quick-equip attempts on SMALL ITEMS to fail and ended up with every SMALL clothing item being equipped into one of the pocket slots (which have no equip delays).
Also fixes quick swap - see the comments below.
Changelog
🆑