Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreigner Minor Fixes #542

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Foreigner Minor Fixes #542

merged 1 commit into from
Jul 12, 2024

Conversation

Mnemotechnician
Copy link
Contributor

Description

#525 Added foreigner traits, now during testing I revealed a few bugs. This PR fixes them:

  • The light version now correctly allows you to understand common (it would not because I forgot to add [DataField])
  • The translator now correctly starts with a high-capacity power cell
  • Equipping the translator in a pocket slot no longer takes time

Media

image

Changelog

🆑

  • fix: Foreigner traits now work correctly.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jul 12, 2024
@SimpleStation14 SimpleStation14 changed the title Foreigner minor fixes Foreigner Minor Fixes Jul 12, 2024
@DangerRevolution DangerRevolution added Size: 4-Small For small issues/PRs Priority: 1-Urgent Must be resolved immediately Type: Bug [Un]intentional issue with something labels Jul 12, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Jul 12, 2024
@VMSolidus VMSolidus merged commit 98d39ca into Simple-Station:master Jul 12, 2024
20 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 12, 2024
@SimpleStation14
Automatic Changelog Update (#542)
4b6ed6e
@FoxxoTrystan FoxxoTrystan mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@DEATHB4DEFEAT DEATHB4DEFEAT Awaiting requested review from DEATHB4DEFEAT

@Peptide90 Peptide90 Awaiting requested review from Peptide90

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist

@OldDanceJacket OldDanceJacket Awaiting requested review from OldDanceJacket

@SimpleStation14 SimpleStation14 Awaiting requested review from SimpleStation14

@NotScoutieBoi NotScoutieBoi Awaiting requested review from NotScoutieBoi

Assignees

@Mnemotechnician Mnemotechnician

Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 1-Urgent Must be resolved immediately Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Bug [Un]intentional issue with something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mnemotechnician @VMSolidus @DangerRevolution