-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ending Punctuation From Emote Detection #561
Merged
DangerRevolution
merged 3 commits into
Simple-Station:master
from
DEATHB4DEFEAT:fix-emote-triggers
Jul 21, 2024
Merged
Remove Ending Punctuation From Emote Detection #561
DangerRevolution
merged 3 commits into
Simple-Station:master
from
DEATHB4DEFEAT:fix-emote-triggers
Jul 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEATHB4DEFEAT
added
Size: 4-Small
For small issues/PRs
Priority: 3-Medium
Needs to be resolved at some point
Type: Bug
[Un]intentional issue with something
Type: Cleanup
Like Rework but small
labels
Jul 18, 2024
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
labels
Jul 18, 2024
75 tasks
SimpleStation14
changed the title
remove ending punctuation from emote detection
Remove Ending Punctuation From Emote Detection
Jul 18, 2024
VMSolidus
requested changes
Jul 18, 2024
VMSolidus
approved these changes
Jul 18, 2024
The video was hidden by a tab, and my ADHD suffering self with no adderall today didn't see the tab. My mistake. Carry on. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Pspritechologist
approved these changes
Jul 21, 2024
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 4-Small
For small issues/PRs
Type: Bug
[Un]intentional issue with something
Type: Cleanup
Like Rework but small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the tons of super inconsistent emote defs with consistent and more dynamic ones.
Media
2024-07-18_02-12-55.mp4
Changelog
🆑