Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ending Punctuation From Emote Detection #561

Merged

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

Replaces the tons of super inconsistent emote defs with consistent and more dynamic ones.


Media

2024-07-18_02-12-55.mp4


Changelog

🆑

  • fix: Emotes now consistently work with any or no punctuation

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small labels Jul 18, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jul 18, 2024
@SimpleStation14 SimpleStation14 changed the title remove ending punctuation from emote detection Remove Ending Punctuation From Emote Detection Jul 18, 2024
@VMSolidus
Copy link
Member

The video was hidden by a tab, and my ADHD suffering self with no adderall today didn't see the tab. My mistake. Carry on.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 21, 2024
@DangerRevolution DangerRevolution merged commit f25fc1e into Simple-Station:master Jul 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants