Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Language Controls #562

Closed
wants to merge 5 commits into from
Closed

Admin Language Controls #562

wants to merge 5 commits into from

Conversation

Mnemotechnician
Copy link
Contributor

Description

Adds 5 new tricks that allow admins/testers to manipulate entities' languages and translators.

The tricks include:

  • Add/remove universal language (UniversalLanguageSpeakerComponent, which overrides all default languages)
  • Add/remove a specific language
  • Edit a translator (spoken, understood, and required languages - all at once because QuickDialogSystem sucks)

This also adds a new supported field type to QuickDialogSystem - boolean, which is represented as a field that lets you input y/n, yes/no, true/false.

Media

8mb.video-Thx-rpvtJ2uH.mp4

Changelog

🆑

  • add: Added admin tricks to manipulate entities' languages and translators.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files labels Jul 18, 2024
@SimpleStation14 SimpleStation14 changed the title Admin language controls Admin Language Controls Jul 18, 2024
@Mnemotechnician
Copy link
Contributor Author

I know there's an admin tooling CL but Iunno how to make the CL get added to it.

@DEATHB4DEFEAT
Copy link
Member

I know there's an admin tooling CL but Iunno how to make the CL get added to it.

The bot doesn't support admin CLs yet

DEATHB4DEFEAT
DEATHB4DEFEAT requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing languages should be commands with autofill, the add/remove universal is fine as a trick.

Content.Shared/Administration/QuickDialogOpenEvent.cs Outdated Show resolved Hide resolved
@Mnemotechnician
Copy link
Contributor Author

Mnemotechnician commented Jul 18, 2024 •
edited
Loading

I can make them as commands, but I know from experience commands (especially those that target entities) are extremely inconvenient to use.

@Mnemotechnician Mnemotechnician mentioned this pull request Jul 19, 2024
Merged
VMSolidus pushed a commit that referenced this pull request Aug 6, 2024
@Mnemotechnician @DEATHB4DEFEAT
Admeme Language Commands (Attempt 2) (#565)
81ad859 
# Description
#562 but using commands instead of tricks.

Less user-friendly but makes you look like a hacker when you use them
:trollface:


<details><summary><h1>Media</h1></summary><p>


![image](https://github.com/user-attachments/assets/818b6226-aea8-4f9a-b30d-5df39b8041e6)

![image](https://github.com/user-attachments/assets/f3c40feb-f84d-4083-bc9a-44f7b1dfb30d)

![image](https://github.com/user-attachments/assets/31827207-4903-4df1-9074-eb060d0cf63c)

(ignore the missing locale, I fixes)

</p></details>

# Changelog

:cl:
- add: Admin tooling: added several admin commands to help manipulate
entities' languages.

---------

Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT requested changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mnemotechnician @DEATHB4DEFEAT