Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species Information in Guidebooks and Shortcut in Character Editor #7

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

Description

Wouldn't it be great if we had Species info in the Guidebook?
Wouldn't it be even better if this was available in the character editor? Now there will be an info button next to the species selection dropdown, complete with hover tooltip. Pressing the button opens the relevant Guidebook page and also loads the other species pages, so the player can click check them all without having to change species in the character editor.


Media

1

2

3

Changelog

🆑 Errant

  • add: Added guidebooks for species
  • add: Species in the character editor have a shortcut to their guidebook entry

* guidebook pages defined

* species info button in character profile editor

* if current species has no guidebook page then open the parent page

* skrek

* destroying evidence of secret vox plot

* icon size adjustment, no icon if guidebook page for species does not exist

* finished pages

* additional info

* weh
@VMSolidus
Copy link
Member

Oh my god that's incredible. Imagine not having to surprise people with the fact that Harpies see Ultraviolet. People can just look at the guidebook and see all their neat features.

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Port Brings something to here from another codebase labels Mar 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title [PORT] Species Information in Guidebooks and Shortcut in Character Editor Species Information in Guidebooks and Shortcut in Character Editor Mar 19, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Mar 21, 2024
@VMSolidus
Copy link
Member

I am incredibly impressed with this, it is quite good work. I've tested it ingame, and have verified that this PR works as advertised. You did some great work here.

@VMSolidus VMSolidus merged commit ee276f7 into Simple-Station:master Mar 23, 2024
10 checks passed
SimpleStation14 added a commit that referenced this pull request Mar 23, 2024
@DEATHB4DEFEAT
Copy link
Member Author

You did some great work here.

I forgot to link the original PR but this is a port (and is labelled as such) of someone elses thing I've been wanting for a while.

gluesniffler pushed a commit to gluesniffler/Einstein-Engines that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants