Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

become psionic obj refactor #93

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #1044: become psionic obj refactor from DeltaV-Station DeltaV-Station/Delta-v

PR opened by

deltanedas at 2024-04-01 17:04:42 UTC PR merged by

deltanedas at 2024-04-03 19:41:47 UTC

e61260849bf6c6be98ea77189497267e4db51726


PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:

  • Changes: C#

Original Body

About the PR

  • use OwnedEntity not CurrentEntity so you dont need to return to body just for greentext, consistent with other objectives
  • general refactor

@Pspritechologist Pspritechologist added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 10, 2024
@github-actions github-actions bot added the Changes: C# Changes any cs files label Apr 15, 2024
@@ -3,9 +3,9 @@
namespace Content.Server.Objectives.Components;

/// <summary>
/// Requires that the player dies to be complete.
/// Requires that the player becomes psionic to be complete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this "player dies" lol?

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:14
@VMSolidus VMSolidus marked this pull request as ready for review May 4, 2024 23:52
@VMSolidus
Copy link
Member

This is actually getting completely removed outright when my Psionic Refactor drops. It's objectively the worst traitor objective, and becomes possible to fail literally in character creation after said refactor.

@VMSolidus VMSolidus closed this May 4, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants