Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over the cryostasis command #29

Closed
wants to merge 5 commits into from

Conversation

Finket
Copy link
Contributor

@Finket Finket commented Jan 9, 2024

Description

Add the cryostasis command from Simple-Station/Parkstation#8.
Adds a frosty machine sound for cryostasis that I created!
Addresses #2.

Handles refactors https://www.github.com/space-wizards/space-station-14/pull/19591, and https://www.github.com/space-wizards/space-station-14/pull/21215.

Note! Deleting the player with _entities.QueueDeleteEntity(uid); appears to throw an error, but it works anyway in my testing.

See the origin PR for the remaining Todo


Media

cryodemo.mp4


Changelog

🆑

  • add: Added cryostasis command
  • add: Added cryostasis sound effect

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Jan 9, 2024
@DEATHB4DEFEAT
Copy link
Member

I'd rather get an actual cryo pod on station like Cosmatic Drift, I'll look into porting that if you don't before I get a chance.

@Finket
Copy link
Contributor Author

Finket commented Jan 9, 2024

I'd rather get an actual cryo pod on station like Cosmatic Drift, I'll look into porting that if you don't before I get a chance.

Fair enough. Would it save the bodies in the cryo pod or delete them like this command does?
I also wanted to design some dramatic cryo pod opening/closing sounds anyway...

@DEATHB4DEFEAT
Copy link
Member

I'd rather get an actual cryo pod on station like Cosmatic Drift, I'll look into porting that if you don't before I get a chance.

Fair enough. Would it save the bodies in the cryo pod or delete them like this command does? I also wanted to design some dramatic cryo pod opening/closing sounds anyway...

It usually deletes the character and puts everything they had on them in a box or something that someone can retrieve later via a terminal in the cryo room, I don't know what permissions if any people usually make it require to retrieve items since I've never retrieved anybody's but whatever access the person had when they cryoed is probably good.

Here are the Cosmatic Drift cryo pod PRs if you want to look at those https://github.com/cosmatic-drift-14/cosmatic-drift/pulls?q=is%3Apr+cryo

@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jan 9, 2024
75 tasks
@Nairodian
Copy link
Contributor

It usually deletes the character and puts everything they had on them in a box or something that someone can retrieve later via a terminal in the cryo room, I don't know what permissions if any people usually make it require to retrieve items since I've never retrieved anybody's but whatever access the person had when they cryoed is probably good.

When someone enters cryo all their stuff gets teleported into a "lost and found" locker, which is HoP access locked and we usually map in their office. That's about all to it.

@DEATHB4DEFEAT
Copy link
Member

It usually deletes the character and puts everything they had on them in a box or something that someone can retrieve later via a terminal in the cryo room, I don't know what permissions if any people usually make it require to retrieve items since I've never retrieved anybody's but whatever access the person had when they cryoed is probably good.

When someone enters cryo all their stuff gets teleported into a "lost and found" locker, which is HoP access locked and we usually map in their office. That's about all to it.

Ah, cool, thanks mister CD!

@Finket Finket closed this Jan 19, 2024
DEATHB4DEFEAT pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants