Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanbok #52

Closed
wants to merge 3 commits into from
Closed

Hanbok #52

wants to merge 3 commits into from

Conversation

toasterpm87
Copy link
Contributor

@toasterpm87 toasterpm87 commented Feb 14, 2024 •
edited by DEATHB4DEFEAT
Loading

Description

Description.

TODO

  • Task
  • Completed Task

Media

Changelog

🆑

  • add: Added fun!
  • tweak: Tweaked fun!
  • fix: Fixed fun!
  • remove: Removed fun!

@toasterpm87
Hanbok
2c2213e 
This reverts commit 6449fe9.

# Description

Description.

---

# TODO

- [ ] Task
- [x] Completed Task

---

<details><summary><h1>Media</h1></summary>
<p>

<!-- ![Example Media Embed](https://example.com/thisimageisntreal.png) -->

</p>
</details>

---

# Changelog

<!-- You can add an author after the `:cl:` to change the name that appears in the changelog, ex: `:cl: Death`, it will default to your GitHub display name -->

:cl:
- add: Added fun!
- tweak: Tweaked fun!
- fix: Fixed fun!
- remove: Removed fun!
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

RSI Diff Bot; head commit b09e098 merging into 9053d1d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Caldera/Clothing/Hanbok.rsi

State Old New Status
Equipped-INNERCLOTHING Added
icon Added

Edit: diff updated after b09e098

@toasterpm87
Copy link
Contributor Author

Hanbok

DEATHB4DEFEAT
DEATHB4DEFEAT previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need to see what psp thinks about the Caldera namespace

@toasterpm87
Copy link
Contributor Author

lgtm, need to see what psp thinks about the Caldera namespace

What's igtm?

@DEATHB4DEFEAT
Copy link
Member

lgtm, need to see what psp thinks about the Caldera namespace

What's igtm?

Looks
Good
To
Me

Pspritechologist
Pspritechologist requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Pspritechologist Pspritechologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caldera namespace is probably fine? Assuming it's actually in the repo, it makes updating it from the source easier.
Bit odd to have just the one entity, but

Resources/Textures/Caldera/Clothing/Hanbok.rsi/icon.png Outdated Show resolved Hide resolved
Resources/Prototypes/Caldera/Clothing/Outfits Outdated Show resolved Hide resolved
Resources/Textures/Caldera/Clothing/Hanbok.rsi/Equipped-INNERCLOTHING.png Outdated Show resolved Hide resolved
Resources/Textures/Caldera/Clothing/Hanbok.rsi/meta.json Outdated Show resolved Hide resolved
@toasterpm87
Copy link
Contributor Author

Caldera namespace is probably fine? Assuming it's actually in the repo, it makes updating it from the source easier.
Bit odd to have just the one entity, but

I will move more things into there.

@toasterpm87
Copy link
Contributor Author

i resolved all thingys

@DEATHB4DEFEAT
Copy link
Member

i resolved all thingys

You don't seem to have pushed changes

@Pspritechologist
Copy link
Member

You've marked everything as resolved, but have not actually updated anything in this pr.

@toasterpm87
Copy link
Contributor Author

You've marked everything as resolved, but have not actually updated anything in this pr.

Lmao I think I forgot to pr

@toasterpm87
Copy link
Contributor Author

im gonna rewrite this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT left review comments

@Pspritechologist Pspritechologist Pspritechologist requested changes

Assignees
No one assigned
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toasterpm87 @DEATHB4DEFEAT @Pspritechologist