Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add an option for cdnjs to jQuery CDNs #8004

Open
wants to merge 1 commit into
base: release-3.0
Choose a base branch
from

Conversation

Oldiesmann
Copy link
Contributor

This PR adds built-in support for loading jQuery from Cloudflare's CDN (aka "cdnjs"). While it doesn't add any additional benefits, it gives us another solid option in addition to the ones provided.

Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
@DiegoAndresCortes
Copy link
Member

DiegoAndresCortes commented Jan 6, 2024

We implemented cloudflare cdn in #7933 when adding fontawesome, we can add it to jquery there

@jdarwood007
Copy link
Member

@DiegoAndresCortes, would you prefer yours or Oldies then? If you want yours, closeout and merge the theme one later.

At another layer. I think we need to abstract the CDN logic. So it's easy to add more providers in the future or remove them. As well as identify which files they can serve, then allow passing or grabbing which 'version' they should be using as defined by our software. A "local" provider is always the SMF install.

@tyrsson
Copy link
Collaborator

tyrsson commented Jan 9, 2024

Personally, I think it would be best to push this to alpha 4 when the other template changes are targeted.

@Oldiesmann
Copy link
Contributor Author

The only theme-related files this touches are a couple of language files. It doesn't modify the templates at all.

@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 4 milestone Jan 11, 2024
@DiegoAndresCortes
Copy link
Member

Both PR's need to wait for #7853 anyways so will just have to wait and decide later.

@jdarwood007 jdarwood007 changed the title Add an option for cdnjs to jQuery CDNs [3.0] Add an option for cdnjs to jQuery CDNs Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants