Increase performance somewhat on profile loading

Simyon264 · Jun 23, 2024 · 93497d4 · 93497d4
1 parent 673a4f9
commit 93497d4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/ReplayBrowser/Helpers/ReplayHelper.cs b/ReplayBrowser/Helpers/ReplayHelper.cs
@@ -82,13 +82,13 @@ public async Task<List<Replay>> GetMostRecentReplays(AuthenticationState state)
             return cachedPlayerData;
         }
 
-        var replays = (await _context.Players
-            .Where(p => p.PlayerGuid == playerGuid)
-            .Include(p => p.Replay)
-            .Include(r => r.Replay.RoundEndPlayers)
-            .Select(p => p.Replay)
-            .ToListAsync()
-            ).DistinctBy(p => p.Id);
+        var replays = await _context.Replays
+            .AsNoTracking()
+            .Include(r => r.RoundEndPlayers)
+            .Where(r => r.RoundEndPlayers != null)
+            .Where(r => r.RoundEndPlayers!.Any(p => p.PlayerGuid == playerGuid))
+            .Distinct() // only need one instance of each replay
+            .ToListAsync();
 
         var charactersPlayed = new List<CharacterData>();
         var totalPlaytime = TimeSpan.Zero;
@@ -99,14 +99,14 @@ public async Task<List<Replay>> GetMostRecentReplays(AuthenticationState state)
 
         foreach (var replay in replays)
         {
-            if (replay == null)
-            {
-                Log.Warning("Replay is null for player with GUID {PlayerGuid}", playerGuid);
+            if (replay.RoundEndPlayers == null)
                 continue;
-            }
 
-            if (replay.RoundEndPlayers == null)
+            if (replay.Date == null)
+            {
+                Log.Warning("Replay with ID {ReplayId} has no date", replay.Id);
                 continue;
+            }
 
             if (replay.Date > lastSeen) // Update last seen
             {

diff --git a/ReplayBrowser/Pages/Profile.razor b/ReplayBrowser/Pages/Profile.razor
@@ -4,6 +4,7 @@
 @using ReplayBrowser.Data
 @using Microsoft.AspNetCore.Components.Web
 @using ReplayBrowser.Helpers
+@using Serilog
 @inject AuthenticationStateProvider AuthenticationStateProvider
 @inject ReplayHelper ReplayHelper
 @attribute [StreamRendering]
@@ -176,6 +177,7 @@ else
             FailedToLoad = true;
             Exception = e;
             _playerData = new();
+            Log.Error(e, "Failed to load player data.");
         }
     }
 }