IllegalArgumentException with Spigot build 2568

[SlimeDog]

Description

This was not an issue with previous spigot build 1.15.1 (Jenkins 2564)

It may be related to It may be related to https://hub.spigotmc.org/jira/browse/SPIGOT-5515

Steps to Reproduce

• Update to Spigot 1.15.1 (Jenkins 2568)
• Start server

Expected Behavior

Errors / Screenshots

[21:23:24] [Server thread/ERROR]: Error occurred while enabling Skript v2.4.1 (Is it up to date?)
java.lang.IllegalArgumentException: Material must be an item: DEAD_TUBE_CORAL_WALL_FAN
        at org.apache.commons.lang.Validate.isTrue(Validate.java:71) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:71) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:58) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:46) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.inventory.ItemStack.<init>(ItemStack.java:36) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at ch.njol.skript.aliases.AliasesProvider.addAlias(AliasesProvider.java:271) ~[?:?]
        at ch.njol.skript.aliases.AliasesParser.loadSingleAlias(AliasesParser.java:705) ~[?:?]
        at ch.njol.skript.aliases.AliasesParser.loadAlias(AliasesParser.java:605) ~[?:?]
        at ch.njol.skript.aliases.AliasesParser.load(AliasesParser.java:123) ~[?:?]
        at ch.njol.skript.aliases.Aliases.load(Aliases.java:504) ~[?:?]
        at ch.njol.skript.aliases.Aliases.load(Aliases.java:490) ~[?:?]
        at ch.njol.skript.aliases.Aliases.lambda$1(Aliases.java:473) ~[?:?]
        at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?]
        at java.util.ArrayList.forEach(ArrayList.java:1540) ~[?:?]
        at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395) ~[?:?]
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) ~[?:?]
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
        at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?]
        at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?]
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
        at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497) ~[?:?]
        at ch.njol.skript.aliases.Aliases.loadDirectory(Aliases.java:466) ~[?:?]
        at ch.njol.skript.aliases.Aliases.loadInternal(Aliases.java:432) ~[?:?]
        at ch.njol.skript.aliases.Aliases.load(Aliases.java:404) ~[?:?]
        at ch.njol.skript.Skript.onEnable(Skript.java:402) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:352) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:417) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:462) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:376) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:456) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:266) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:783) [spigot-1.15.1.jar-2020-01-14-2045:git-Spigot-037559e-752cf95]
        at java.lang.Thread.run(Thread.java:834) [?:?]

Server Information

• Server version/platform: Spigot 1.15.1 (Jenkins 2568)
• Skript version: 2.4.1

Additional Context

[ShaneBeee]

Oyy, I saw md_5's commit regarding this, I was wondering if it was going to break something.

[SlimeDog]

It broke many things, in many different plugins. I have reverted to Jenkins 2564. Test servers. :)

[ShaneBeee]

It broke many things, in many different plugins.

Oyy, this ought to be fun to fix

[ShaneBeee]

md_5 just reverted this change after a few people explained the ramifications of the change.
By the sounds of what he said, this is just temporary and we are not sure if/when it will be coming back.

That said, I am going to keep this issue open as we will have to "solve" it at some point, before Spigot makes this change again.

[bensku]

Skript is not using ItemStack against Javadoc specification, and this is a large functional change. Flagging as enchantment. We'll need to look at this regardless.

I suppose one fix would be eliminating use of ItemStacks for non-item materials.

[SlimeDog]

I suppose one fix would be eliminating use of ItemStacks for non-item materials.

That seems prudent.

Confirmed that the error is not present in Spigot build 2569 (the reversion).

[bensku]

Skript is already aware of items that do not have block form, so this shouldn't be that much of work. It will require making some public Java APIs nullable, which might silently break some addons.