Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cherry picking action #6016

Closed
wants to merge 4 commits into from
Closed

Conversation

Pikachu920
Copy link
Member

Description

This PR adds an action that will automatically open a cherry pick pull request for merged PRs that have a version tag on them (e.g. 2.7). It is functionally the same as #5906 but it works by dynamically identifying version labels rather than having one action for each label.

Before merging someone with the permissions to do so will need to enable these options:

  1. Go to https://github.com/organizations/SkriptLang/settings/actions and enable "Allow GitHub Actions to create and approve pull requests"
  2. Go to https://github.com/SkriptLang/Skript/settings/actions and enable "Allow GitHub Actions to create and approve pull requests"

Without these settings enabled, the action can't open a PR. See the GitHub blog here for info on the setting.

Caveats:

  • This action will only work for PRs merged from SkriptLang/Skript branches and not from branches on forks. This might be possible to fix in the future but there are more security considerations there so I'm leaving it off for now.

Test cases:

  • Merging a PR without labels: Job passes gracefully
  • Merging a PR without a version target label (e.g. 2.7): Job passes gracefully without opening PR
  • Merging a PR with multiple version labels (e.g. it has both 2.7 and 2.8): Job passes gracefully without opening PR
  • Merging a PR with one version label: Job passes gracefully and opens PR

Target Minecraft Versions: N/A
Requirements: N/A
Related Issues: N/A

@Pikachu920 Pikachu920 closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant