Raise the minimum Java version to 11. #6557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
approved these changes
Apr 12, 2024
sovdeeth
approved these changes
Apr 12, 2024
sovdeeth
added
the
enhancement
|
This is probably to be the last thing merged before 2.9, in case anybody needs to make an unofficial Java 8 build by checking out the final commit. Ironically, the first post-2.9 feature commit will probably be bumping the version again to Java 17. |
Moderocky
added
the
feature-ready
sovdeeth
requested changes
May 7, 2024
There was a problem hiding this comment.
Line 23 in b0052d2
change 1.8 to 1.12 (and resolve conflicts :) )
sovdeeth
approved these changes
May 7, 2024
UnderscoreTud
approved these changes
May 7, 2024
Moderocky
added
breaking changes
APickledWalrus
approved these changes
May 8, 2024
|
Make it Java 17. Java 11 doesn't benefit much. Other than less MC versions from 1.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raises Skript's compile target from Java 8 to Java 11.
Raises the test runners (and test server tasks) to use Java 11.
With 2.9 we are dropping support for Java 8. We will still support Minecraft versions 1.13.2+ with this Skript version, as long as they are running Java 11.
Target Minecraft Versions: any
Requirements: Java 11
Related Issues: #4625 & closes #1321