1.20.5 Support #6617
Merged
1.20.5 Support #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now targets to the 1.20.5 support branch
This is useful for items that have NBT that is not represented by an ItemMeta implementation (e.g. block entity data)
APickledWalrus
added
bug
ShaneBeee
approved these changes
Apr 27, 2024
Moderocky
approved these changes
Apr 27, 2024
AyhamAl-Ali
approved these changes
Apr 27, 2024
Moderocky
added
the
patch-ready
Also updates Java from 17 to 21
Removed ones do not currently work on new versions...
We cannot use EasyMock on Java 21 as we must stay on an older version (see #6204 (comment)) Java 21 will be supported for regular testing. A 1.20.4 environment remains for Java 17
APickledWalrus
commented
Apr 30, 2024
sovdeeth
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to provide basic support for 1.20.5. That is, Skript will load and unload without errors.
Due to the data component changes in 1.20.5, any NBT based alias broke. This PR includes changes to the alias loading process to support data components in aliases. Item components for aliases are written as follows:
minecraft:potion {minecraft:potion_contents={"potion":"minecraft:night_vision"}}. Internally,{<>}is treated as[<>]and the string within is assumed to be a valid data component format. For more details, see:NOTE: The skript-aliases PR is required and must be merged first. Once it is merged, I will update this PR to revert the changes to the submodule settings.
Target Minecraft Versions: any
Requirements: none
Related Issues: fixes #6629