Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EffBan - add option to kick #6835

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR adds an option to kick when banning players.
It's a common misconception that people assuming banning kicks the player as well.
This helps eliminate the need for 2 lines

Did a little code cleanup too.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

- also did a lil cleanup
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.9 Targeting a 2.9.X version release labels Jun 30, 2024
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 1, 2024
@sovdeeth sovdeeth added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Jul 1, 2024
@sovdeeth sovdeeth merged commit a4f38d2 into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the feature/banandkick branch July 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants