Fix NPE caused by unregistered ClassInfo #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Sep 17, 2024
sovdeeth
added
the
bug
cheeezburga
approved these changes
Sep 17, 2024
Moderocky
approved these changes
Sep 17, 2024
Moderocky
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a null pointer caused when an unregistered ClassInfo is in an accepted changes list, and the change type is not valid. There may be other execution paths affected by this.
The proposed change will use the class' full path (or primitive name) as a fallback value in the error message if there is no ClassInfo.
Target Minecraft Versions: any
Requirements: none
Related Issues: none