Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Item Flags #7086

Open
wants to merge 23 commits into
base: dev/feature
Choose a base branch
from
Open

Add Item Flags #7086

wants to merge 23 commits into from

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Sep 17, 2024 •
edited
Loading

Description

This PR aims to add item flags to Skript, similar to SkBee's syntax, (I think anyway, I can't access the repo currently 😅 )

Target Minecraft Versions: any
Requirements: none
Related Issues: none

sovdeeth
sovdeeth requested changes Sep 17, 2024
View reviewed changes
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlagsItem.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlagsItem.java Outdated Show resolved Hide resolved
src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
cheeezburga
cheeezburga suggested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already a fair few things from others, so just some small stuff for now

src/main/java/ch/njol/skript/classes/data/BukkitClasses.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlagsItem.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlagsItem.java Outdated Show resolved Hide resolved
src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlagsItem.java Outdated Show resolved Hide resolved
@cheeezburga
Copy link
Member

Needs tests

@cheeezburga cheeezburga added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 18, 2024
Fusezion
Fusezion suggested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick little overview

src/main/java/ch/njol/skript/classes/data/BukkitClasses.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprItemFlags.sk Outdated Show resolved Hide resolved
Fusezion
Fusezion approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concerns were fixed, and didn't see anything else that was worrisome

@Fusezion Fusezion mentioned this pull request Sep 19, 2024
Merged
sovdeeth
sovdeeth requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

src/main/java/ch/njol/skript/classes/data/BukkitClasses.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Show resolved Hide resolved
@Asleeepp @sovdeeth
Update src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java
a37e548 
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
cheeezburga
cheeezburga suggested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still of the opinion that hidden x, like hidden enchants, should be valid too

@Asleeepp
Copy link
Contributor Author

I'm still of the opinion that hidden x, like hidden enchants, should be valid too

🥴

@Asleeepp @Efnilite
Apply suggestions from code review
a7f1844 
Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>
@cheeezburga cheeezburga added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneBeee ShaneBeee ShaneBeee requested changes

@Fusezion Fusezion Fusezion approved these changes

@cheeezburga cheeezburga cheeezburga approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Asleeepp @cheeezburga @sovdeeth @Moderocky @ShaneBeee @Efnilite @Fusezion