Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid legacy materials in aliases and expritems #7087

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

sovdeeth
Copy link
Member

Description

removes legacy materials from two instances where skript iterates over all materials.
Was causing issues when running with paper's new paper.disableOldApiSupport startup flag.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.9 Targeting a 2.9.X version release labels Sep 17, 2024
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:pepe_clap: (you gotta use your imagination for this one)
Thank you for this!

Co-authored-by: Efy <35348263+Efnilite@users.noreply.github.com>
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray now I won't need to wait 10 seconds for legacy to load itself, not approval blocking but could we remove license from Aliases.java

@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 18, 2024
@UnderscoreTud UnderscoreTud merged commit cb6d995 into SkriptLang:dev/patch Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants