Preventing NPE caused by creation of PlayerProfile from OfflinePlayer #7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Sep 18, 2024
sovdeeth
added
bug
TheLimeGlass
requested changes
Sep 18, 2024
TheLimeGlass
approved these changes
Sep 20, 2024
Efnilite
approved these changes
Sep 20, 2024
Efnilite
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's currently a bug when setting the profile of a skull using an OfflinePlayer without a username. SkullMeta#setOwningPlayer(OfflinePlayer) do not check if the username is present and still creates a new GameProfile, leading to a NPE. This PR addresses the issue by providing an alternative player profile with empty username.
Although this has been fixed in SPIGOT-7882 (the same way I did here), the bug persists in older versions supported by Skript.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7090