Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow delay within the testing system #7095

Open
wants to merge 5 commits into
base: dev/patch
Choose a base branch
from
Open

Disallow delay within the testing system #7095

wants to merge 5 commits into from

Conversation

TheLimeGlass
Copy link
Collaborator

@TheLimeGlass TheLimeGlass commented Sep 19, 2024 •
edited
Loading

Description

Disallow delay within the testing system.

Testing System Info:

  • The script testing system happens instantaneous.
  • Anything delayed does not properly get collected after the delay and assertions become useless.
  • JUnit can be delayed.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Pesekjak Pesekjak added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 19, 2024
@TheLimeGlass @Pesekjak
Update src/test/skript/tests/syntaxes/expressions/ExprEntities.sk
ae290bd 
Co-authored-by: Pesek <42549665+Pesekjak@users.noreply.github.com>
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Pesekjak Pesekjak Pesekjak approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheLimeGlass @sovdeeth @Efnilite @Pesekjak