Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fireworks Fix #7131

Open
wants to merge 16 commits into
base: dev/feature
Choose a base branch
from
Open

Fireworks Fix #7131

wants to merge 16 commits into from

Conversation

TheAbsolutionism
Copy link

Description

This PR aims to fix the firework event when using a color type
Also adds a colors event-value

Target Minecraft Versions: any
Requirements: none
Related Issues: #6091

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 5, 2024
Fusezion
Fusezion suggested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small change to remove some needless conversions

src/main/java/ch/njol/skript/events/EvtFirework.java Outdated Show resolved Hide resolved
Fusezion
Fusezion approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fusezion Fusezion Fusezion approved these changes

@Efnilite Efnilite Efnilite approved these changes

@TheLimeGlass TheLimeGlass TheLimeGlass approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Awaiting requested review from Moderocky

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheAbsolutionism @sovdeeth @TheLimeGlass @Efnilite @Fusezion