Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to BoldText and ChangeTextSound #528

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Adex-8x
Copy link
Contributor

@Adex-8x Adex-8x commented Jul 28, 2024

Some minor improvements to two patches:

  • BoldText: When characters' widths are read while bold text is active, then it will be increased by 1 to prevent characters from bleeding into one another.
  • ChangeTextSound: Added an optional second parameter to the text tag specifying the volume. If the text tag is used without a volume parameter, it defaults to 256.

Copy link

Test Results

    14 files  ±0      14 suites  ±0   52m 46s ⏱️ -6s
10 894 tests ±0  10 893 ✅ ±0      1 💤 ±0  0 ❌ ±0 
32 848 runs  ±0  26 104 ✅ ±0  6 744 💤 ±0  0 ❌ ±0 

Results for commit 5668d40. ± Comparison against base commit 6da487a.

@theCapypara theCapypara merged commit 56be822 into SkyTemple:master Aug 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants