Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Further optimize new Pmd2ScriptData (#529)" #537

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

theCapypara
Copy link
Member

@theCapypara theCapypara commented Aug 6, 2024

This reverts commit 5c3ff2a, PR #529

Closes SkyTemple/skytemple#796

The logic didn't actually invalidate the cache...

Copy link

github-actions bot commented Aug 6, 2024

Test Results

    14 files  ±0      14 suites  ±0   53m 11s ⏱️ + 1m 14s
10 900 tests ±0  10 899 ✅ ±0      1 💤 ±0  0 ❌ ±0 
32 896 runs  ±0  26 128 ✅ ±0  6 768 💤 ±0  0 ❌ ±0 

Results for commit 449d35c. ± Comparison against base commit 8eaf240.

@theCapypara theCapypara merged commit 868cf16 into master Aug 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when placing a non-vanilla actor in a scene
1 participant