Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mithril carpet highlighter #1034

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Oct 27, 2024

Renders a colored box around nearby carpets within mithril ore veins in dwarven mines.
image
It can be toggled on and off, and the color is configurable.
image
Uses up about 0.30% of tick time for scanning & rendering while in dwarven mines. Didn't test outside but it should be much less, probably not even worth mentioning as it's just a boolean if check on each tick.
image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Oct 27, 2024
Copy link
Contributor

@olim88 olim88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like good code to me.

@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. reviews needed This PR needs reviews and removed reviews needed This PR needs reviews merge conflicts This PR has merge conflicts that need solving. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviews needed This PR needs reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants