Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waypoints refactor #976

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Waypoints refactor #976

wants to merge 16 commits into from

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Sep 1, 2024 •
edited
Loading

Add ordered waypoint support in gui.
All ordered waypoints made with commands will be migrated to waypoints.

API Changes

I have tried to keep API changes to a minimum, but here are the relatively large changes:

  • Waypoint#render now checks Waypoint#shouldRender.
    • This allows only rendering the name by overriding shouldRender to false and shouldRenderName to true.
  • NamedWaypoint#shouldRenderName now defaults to Waypoint#shouldRender.
    • You now need to override shouldRenderName to always render the name.

Bug Fixes

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Sep 1, 2024
@AzureAaron AzureAaron added this to the 1.23.0 milestone Sep 1, 2024
viciscat
viciscat previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I suppose but did not test, might do that at some point.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 17, 2024
@kevinthegreat1
Copy link
Collaborator Author

I’ll wait for aaron to look at this pr.

@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Sep 20, 2024
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Sep 21, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Sep 21, 2024
@kevinthegreat1
Copy link
Collaborator Author

Closes #1024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat left review comments

@AzureAaron AzureAaron Awaiting requested review from AzureAaron

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
reviews needed This PR needs reviews
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

waypoints not working
4 participants
@kevinthegreat1 @viciscat @AzureAaron @LifeIsAParadox