-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dungeon Score improvements (on another branch) #490
Open
Desco1
wants to merge
34
commits into
Skytils:2.x-legacyfabricexp
Choose a base branch
from
Desco1:2.x-legacyfabricexp
base: 2.x-legacyfabricexp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a469fbe
refactor the class for clarity
Desco1 dd9c0fa
sorta functional min and can skip secrets
Desco1 c26cfe3
fix for max secrets and rerolled puzzles
Desco1 2bb3de4
chest profit render fix
Desco1 dc548ec
sa boots fix (and maybe others)
Desco1 a108b41
feat: make all dungeon solver colors customizable (#487)
Coccocoahelper 309dcc2
puzzle display
Desco1 4886594
reset blaze done on puzzle reroll
Desco1 70867d7
remove unused setting
Desco1 7cb8751
only marginally more readable
Desco1 941a1d7
Merge branch 'Skytils:dev' into dev
Desco1 17c6efe
Merge branch 'refs/heads/dev' into 2.x-legacyfabricexp
Desco1 132c3d5
migrate ScoreCalculation to custom event system
Desco1 eb88d6c
Merge branch 'Skytils:2.x-legacyfabricexp' into 2.x-legacyfabricexp
Desco1 13c5152
refactor the class for clarity
Desco1 d4aed9c
sorta functional min and can skip secrets
Desco1 bfeabe4
fix for max secrets and rerolled puzzles
Desco1 2dfe29d
chest profit render fix
Desco1 ab6adc5
sa boots fix (and maybe others)
Desco1 87c2388
puzzle display
Desco1 dd8193d
reset blaze done on puzzle reroll
Desco1 4d6d7bf
remove unused setting
Desco1 f0f6742
only marginally more readable
Desco1 e24f73d
feat: make all dungeon solver colors customizable (#487)
Coccocoahelper 42207b2
migrate ScoreCalculation to custom event system
Desco1 60b03f2
delay paul check
Desco1 f0fec1e
Merge branch 'Skytils:2.x-legacyfabricexp' into 2.x-legacyfabricexp
Desco1 a8fb3f9
Merge remote-tracking branch 'origin/2.x-legacyfabricexp' into 2.x-le…
Desco1 7d9becc
enable dungeon status/breakdown by default
Desco1 d1c033d
improve readability again
Desco1 ac6d6bb
Merge branch '2.x-legacyfabricexp' into 2.x-legacyfabricexp
Desco1 29ae4ba
actually resolve conflict
Desco1 183f54e
fix wrong event on blaze done
Desco1 6313b4c
don't detect reset puzzles twice
Desco1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR removes "minimized score estimate", it might be useful to mention that this toggle is effectively the opposite of it. Maybe something along the lines of "Disabling this will minimize the dungeon score"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about specifying for a deprecated setting, but yeah the settings are the exact opposite, could maybe be convenient to flip them as "Hide Dungeon Status/Score Breakdown" instead. Also, the previous setting was disabled by default, maybe the new ones (if not changed from "Show") could be enabled to keep default functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I meant mostly for users who are used to the previous settings/names.